Feat/item buffer #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumtilbury
suggested changes
Dec 9, 2023
|
We should add the item buffer to the README too :) |
Co-authored-by: Callum Tilbury <37700709+callumtilbury@users.noreply.github.com>
Co-authored-by: Callum Tilbury <37700709+callumtilbury@users.noreply.github.com>
Co-authored-by: Callum Tilbury <37700709+callumtilbury@users.noreply.github.com>
Co-authored-by: Callum Tilbury <37700709+callumtilbury@users.noreply.github.com>
Co-authored-by: Callum Tilbury <37700709+callumtilbury@users.noreply.github.com>
Co-authored-by: Callum Tilbury <37700709+callumtilbury@users.noreply.github.com>
callumtilbury
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a simple wrapper for the trajectory buffer much like the flat buffer.
Why?
A lot of users seem to require a buffer for completely independent data items. This can be easily achieved by using a trajectory buffer with a period of 1 and sequence length of 1 however it requires removing the time dimension every time a user samples a batch and adding a time dimension every time a user adds a batch.
How?
The wrapper provides the same utility as the flat buffer allowing users to choose whether they add batches, sequences or both. Additionally, since data items are completely independent, all data is flattened along the batch dimension thus allowing a user to specify an exact buffer size which is not possible when using the square structure of the trajectory buffer normally.